Merge pull request #1 from andreygubarev/feature-linter

feature linter
andreygubarev · May 25, 2023 · dd8f7a6 · dd8f7a6
2 parents e5faf32 + 529ef51
commit dd8f7a6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -18,7 +18,7 @@ virtualenv: $(ANSIBLE_VIRTUALENV) ## Create local environment
 
 .PHONY: lint
 lint: virtualenv ## Lint
-	$(ANSIBLE_VIRTUALENV)/bin/ansible-lint -v
+	$(ANSIBLE_VIRTUALENV)/bin/ansible-lint -v molecule_qemu
 	$(ANSIBLE_VIRTUALENV)/bin/pycodestyle molecule_qemu
 
 .PHONY: clean

diff --git a/molecule_qemu/playbooks/create.yml b/molecule_qemu/playbooks/create.yml
@@ -54,6 +54,8 @@
         -f qcow2
         -o backing_file={{ item.vm_image }},backing_fmt={{ item.vm_image_format }}
         {{ item.vm_run_diskfile }}
+      args:
+        creates: "{{ item.vm_run_diskfile }}"
       loop: "{{ molecule_instances }}"
       loop_control:
         label: "{{ item.name }}"
@@ -93,6 +95,8 @@
         -joliet
         -rock
         {{ molecule_ephemeral_directory }}/run/cloud-init/{{ item.name }}/
+      args:
+        creates: "{{ molecule_ephemeral_directory }}/run/cloud-init/{{ item.name }}.iso"
       loop: "{{ molecule_instances }}"
       loop_control:
         label: "{{ item.name }}"

diff --git a/molecule_qemu/playbooks/destroy.yml b/molecule_qemu/playbooks/destroy.yml
@@ -24,7 +24,9 @@
       register: qemu_processes
 
     - name: Destroy running VMs
-      ansible.builtin.shell: "kill {{ item.ansible_facts.pid }}"
+      ansible.builtin.command: >
+        kill {{ item.ansible_facts.pid }}
+      changed_when: false
       loop: "{{ qemu_processes.results }}"
       loop_control:
         label: "{{ item.item.name }}"