Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pigg 384 #728

Merged
merged 37 commits into from
Dec 15, 2024
Merged

Pigg 384 #728

merged 37 commits into from
Dec 15, 2024

Conversation

andrewdavidmackenzie
Copy link
Owner

@andrewdavidmackenzie andrewdavidmackenzie commented Dec 8, 2024

Add mDNS discovery - announcing in piglet & porky, query in piggui
Fixes #384
Fixes #730

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 4.93827% with 231 lines in your changes missing coverage. Please review.

Project coverage is 29%. Comparing base (5dacc36) to head (8e43667).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
src/discovery.rs 0% 76 Missing ⚠️
src/piglet.rs 0% 44 Missing ⚠️
src/host_net/iroh_host.rs 0% 37 Missing ⚠️
src/piggui.rs 0% 25 Missing ⚠️
src/views/hardware_menu.rs 0% 23 Missing ⚠️
src/usb.rs 0% 12 Missing ⚠️
src/views/hardware_view.rs 0% 8 Missing ⚠️
src/hardware_subscription.rs 0% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #728    +/-   ##
======================================
- Coverage      29%    29%    -0%     
======================================
  Files          46     45     -1     
  Lines        5694   5835   +141     
======================================
+ Hits         1622   1634    +12     
- Misses       4072   4201   +129     
Flag Coverage Δ
unittests 29% <5%> (-<1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewdavidmackenzie andrewdavidmackenzie marked this pull request as draft December 12, 2024 11:44
@andrewdavidmackenzie
Copy link
Owner Author

Some remaining issues with TTL of mdns on porky to work out before we should merge.
Then change the Ttl to 60 seconds or something similar.

@andrewdavidmackenzie andrewdavidmackenzie marked this pull request as ready for review December 15, 2024 10:16
@andrewdavidmackenzie andrewdavidmackenzie merged commit 3dc7fe9 into master Dec 15, 2024
17 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the pigg_384 branch December 15, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant