Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased parallelization #2005

Merged
merged 97 commits into from
Sep 3, 2023
Merged

Increased parallelization #2005

merged 97 commits into from
Sep 3, 2023

Conversation

andrewdavidmackenzie
Copy link
Owner

Fixes #1996

andrewdavidmackenzie and others added 26 commits August 22, 2023 09:52
@andrewdavidmackenzie
Consume the array and avoid clone
7301892
@andrewdavidmackenzie
Limit length of comments
236c92b
@andrewdavidmackenzie
Refactoring
c4a3d41
@andrewdavidmackenzie
Input::take and count() take into account initializers
0b576a6
@andrewdavidmackenzie
Add an accessor for initializer
b065750
@andrewdavidmackenzie
Add is_always_ready() method
bdcfa21
@andrewdavidmackenzie
Reimplement make_ready() to generate many jobs
52dae38
@andrewdavidmackenzie
Remove comment
cbd8a9a
@andrewdavidmackenzie
Refactor
b69c55f
@andrewdavidmackenzie
Add test
52ef5c8
@andrewdavidmackenzie
Improve README.md
d7ebfdf
@andrewdavidmackenzie
Increased parallelization - but leads to out of order execution and t…
1e4385a 
…est failures in matrix_mult and sequence of sequences
@andrewdavidmackenzie
Fix count imports
2d26341
@andrewdavidmackenzie
Ignore parallel test for now
101d59b
@dependabot
build(deps): bump clap from 4.3.23 to 4.3.24 (#2008)
608fb12 
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.23 to 4.3.24.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.3.23...v4.3.24)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump serde from 1.0.185 to 1.0.186 (#2007)
53ffb4c 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.185 to 1.0.186.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.185...v1.0.186)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@andrewdavidmackenzie
Correct the matrix multiplication DESCRIPTION.md
21d740e
@andrewdavidmackenzie
Correct some strings
9552a3b
@andrewdavidmackenzie
Improve description
68c2182
@andrewdavidmackenzie
Strop maintaining a queue length variable
3b8632b
@andrewdavidmackenzie
Improve error message
f101886
@andrewdavidmackenzie
Improve debugging message
4a87a9c
@andrewdavidmackenzie
Factor out retire_jobs()
f26197b
@andrewdavidmackenzie
Add comment
2287af4
@andrewdavidmackenzie
Improve debug message
62eba0e
@andrewdavidmackenzie
Make the WAIT/DONT_WAIT semantics explicit
3d88913
@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 93% and project coverage change: +1% 🎉

Comparison is base (ec67a07) 84% compared to head (ebe8556) 84%.
Report is 10 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #2005   +/-   ##
======================================
+ Coverage      84%     84%   +1%     
======================================
  Files         151     152    +1     
  Lines       18563   18597   +34     
======================================
+ Hits        15580   15616   +36     
+ Misses       2983    2981    -2
Files Changed Coverage Δ
flowr/src/bin/flowrcli/cli/cli_client.rs 87% <0%> (-<1%) ⬇️
flowr/src/bin/flowrgui/main.rs 2% <0%> (+1%) ⬆️
flowstdlib/src/lib.rs 100% <ø> (ø)
flowstdlib/src/math/range.rs 100% <ø> (ø)
flowstdlib/src/math/sequence.rs 100% <ø> (ø)
flowr/src/lib/coordinator.rs 85% <71%> (+4%) ⬆️
flowc/src/bin/flowc/lib_build.rs 91% <90%> (-<1%) ⬇️
flowr/src/lib/run_state.rs 96% <97%> (-<1%) ⬇️
flowstdlib/src/matrix/multiply_row/multiply_row.rs 98% <98%> (ø)
...stdlib/src/matrix/compose_matrix/compose_matrix.rs 99% <99%> (ø)
... and 11 more

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dependabot bot and others added 3 commits August 28, 2023 09:44
@dependabot
build(deps): bump wasmtime from 12.0.0 to 12.0.1 (#2012)
b2110e8 
Bumps [wasmtime](https://github.com/bytecodealliance/wasmtime) from 12.0.0 to 12.0.1.
- [Release notes](https://github.com/bytecodealliance/wasmtime/releases)
- [Changelog](https://github.com/bytecodealliance/wasmtime/blob/main/docs/WASI-some-possible-changes.md)
- [Commits](bytecodealliance/wasmtime@v12.0.0...v12.0.1)

---
updated-dependencies:
- dependency-name: wasmtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump serde from 1.0.186 to 1.0.188 (#2013)
9ce4d37 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.186 to 1.0.188.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.186...v1.0.188)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@andrewdavidmackenzie
Small refactoring
28d247c
@andrewdavidmackenzie
Fix link
d26bd7b
@andrewdavidmackenzie
Order modules and functions in manifest
e799a4e
@andrewdavidmackenzie
newline
9fe0e9d
@andrewdavidmackenzie
Fix multiply.toml and improve lib_build output
e006daa
@andrewdavidmackenzie
Fix clippy
4c6705f
@andrewdavidmackenzie
Remove matrix_mult as an example and correct its test in lib
10edf6e
@andrewdavidmackenzie
Fix book reference
8f0b831
@andrewdavidmackenzie
Formatting
fa03965
@andrewdavidmackenzie
typo
71db70a
@andrewdavidmackenzie
improve text
3456158
@andrewdavidmackenzie
Text output tweaks
9f7d993
@andrewdavidmackenzie
Cargo update
314401b
@andrewdavidmackenzie
Cargo update
fad8f58
@andrewdavidmackenzie
Merge remote-tracking branch 'origin/flow-1996' into flow-1996
a673068 
# Conflicts:
#	flowstdlib/src/matrix/multiply.rs
@andrewdavidmackenzie
Change multiply_row to have multiple outputs
292018b
@andrewdavidmackenzie
Change multiply_row to have multiple outputAdd row indexing to duplic…
2884564 
…ate_rows and index combining in multiply_rows
@andrewdavidmackenzie
Rename transpose output to "matrix"
a44eaa4
@andrewdavidmackenzie
Add column indexes to matrix transpose and duplicate them in multiply…
9a73886 
… flow also
@andrewdavidmackenzie
Add a compose_matrix function in flowstdlib
3af192d
@andrewdavidmackenzie
Add to lib and fix clippys
7c25486
@andrewdavidmackenzie
Get compose_matrix more or less working
4e7c78b
@andrewdavidmackenzie
Write to specific matrix cells using indexes
b8d1af9
@andrewdavidmackenzie
Add some docs to the multiply flow. Add compose_matrix to SUMMARY.
8671329
@andrewdavidmackenzie
Improve docs on parallelism and order
c9c9dcb
@andrewdavidmackenzie
Remove test
f23ff8f
@andrewdavidmackenzie
Fix sequence of sequences
a37b3af
@andrewdavidmackenzie
Remove TODOS and simplift input.take()
ebe8556
@andrewdavidmackenzie
Copy link
Owner Author

increased the max number of jobs in parallel for mandlebrot example from 4 to 48

@andrewdavidmackenzie andrewdavidmackenzie merged commit 8ff27d8 into master Sep 3, 2023
6 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the flow-1996 branch September 3, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallelization checks
1 participant
@andrewdavidmackenzie