#[132577191] Send Regret Email #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 21, 2016
| @@ -0,0 +1,4 @@ | |||
| # Preview all emails at http://localhost:3000/rails/mailers/regret_mailer | |||
| class RegretMailerPreview < ActionMailer::Preview | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at class body beginning.
houndci-bot
reviewed
Nov 21, 2016
| @@ -0,0 +1,4 @@ | |||
| # Preview all emails at http://localhost:3000/rails/mailers/regret_mailer | |||
| class RegretMailerPreview < ActionMailer::Preview | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at class body beginning.
houndci-bot
reviewed
Nov 21, 2016
| expect(page).to have_content(artisan.firstname) | ||
| expect(page).to have_content(artisan.email) | ||
| end | ||
| end | ||
|
|
||
|
|
houndci-bot
reviewed
Nov 21, 2016
| expect(page).to have_content(artisan.firstname) | ||
| expect(page).to have_content(artisan.email) | ||
| end | ||
| end | ||
|
|
||
|
|
houndci-bot
reviewed
Nov 21, 2016
| enum status: [:not_reviewed, :strong_yes, | ||
| :yes, :no, :strong_no, :certified] | ||
| :yes, :no, :strong_no,:certified, :accepted_emailed, :rejected_emailed] |
There was a problem hiding this comment.
Space missing after comma.
Line is too long. [87/80]
houndci-bot
reviewed
Nov 21, 2016
| enum status: [:not_reviewed, :strong_yes, | ||
| :yes, :no, :strong_no, :certified] | ||
| :yes, :no, :strong_no,:certified, :accepted_emailed, :rejected_emailed] |
There was a problem hiding this comment.
Space missing after comma.
Line is too long. [87/80]
houndci-bot
reviewed
Nov 21, 2016
| @user = user | ||
| @body = body | ||
| mail(to: @user.email, subject: "Job Offer #{user.firstname}") | ||
| end |
houndci-bot
reviewed
Nov 21, 2016
| @user = user | ||
| @body = body | ||
| mail(to: @user.email, subject: "Job Offer #{user.firstname}") | ||
| end |
houndci-bot
reviewed
Nov 21, 2016
| def regret_email(user, body) | ||
| @user = user | ||
| @body = body | ||
| mail(to: @user.email, subject: "Job Offer #{user.firstname}") |
houndci-bot
reviewed
Nov 21, 2016
| class RegretMailer < ApplicationMailer | ||
| def regret_email(user, body) | ||
| @user = user | ||
| @body = body |
houndci-bot
reviewed
Nov 21, 2016
| def regret_email(user, body) | ||
| @user = user | ||
| @body = body | ||
| mail(to: @user.email, subject: "Job Offer #{user.firstname}") |
houndci-bot
reviewed
Nov 21, 2016
| @@ -0,0 +1,7 @@ | |||
| class RegretMailer < ApplicationMailer | |||
| def regret_email(user, body) | |||
| @user = user | |||
There was a problem hiding this comment.
Tab detected.
Use 2 (not 1) spaces for indentation.
houndci-bot
reviewed
Nov 21, 2016
| class RegretMailer < ApplicationMailer | ||
| def regret_email(user, body) | ||
| @user = user | ||
| @body = body |
houndci-bot
reviewed
Nov 21, 2016
| @@ -0,0 +1,7 @@ | |||
| class RegretMailer < ApplicationMailer | |||
| def regret_email(user, body) | |||
There was a problem hiding this comment.
Use 2 (not 1) spaces for indentation.
Tab detected.
houndci-bot
reviewed
Nov 21, 2016
| @@ -0,0 +1,7 @@ | |||
| class RegretMailer < ApplicationMailer | |||
| def regret_email(user, body) | |||
| @user = user | |||
There was a problem hiding this comment.
Tab detected.
Use 2 (not 1) spaces for indentation.
houndci-bot
reviewed
Nov 21, 2016
| @rejected_users = User.artisans.rejected | ||
| body = params[:body] | ||
| @rejected_users.each do |user| | ||
| RegretMailer.regret_email(user, body).deliver_now |
There was a problem hiding this comment.
Use 2 (not 0) spaces for indentation.
houndci-bot
reviewed
Nov 21, 2016
| @@ -0,0 +1,7 @@ | |||
| class RegretMailer < ApplicationMailer | |||
| def regret_email(user, body) | |||
There was a problem hiding this comment.
Use 2 (not 1) spaces for indentation.
Tab detected.
houndci-bot
reviewed
Nov 21, 2016
| @rejected_users = User.artisans.rejected | ||
| body = params[:body] | ||
| @rejected_users.each do |user| | ||
| RegretMailer.regret_email(user, body).deliver_now |
There was a problem hiding this comment.
Use 2 (not 0) spaces for indentation.
victor-kironde
force-pushed
the
ft-artisan-regret-email-132577191
branch
from
118744a to
f0ae832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What are the relevant pivotal tracker stories?
closes
132577191