Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_available_gpus and set_gpus #17

Merged
merged 10 commits into from
Jul 5, 2024
Merged

Update get_available_gpus and set_gpus #17

merged 10 commits into from
Jul 5, 2024

Conversation

AlexeyKozhevin
Copy link
Contributor

@AlexeyKozhevin AlexeyKozhevin commented Jul 3, 2024 •
edited
Loading

  • Sync with BF version (also removed all these functions from it): min_free_memory can be float (ratio of memory) or int (megabytes)
  • nvidia_smi -> pynvml
  • Update setup.py

SergeyTsimfer
SergeyTsimfer reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@SergeyTsimfer SergeyTsimfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

What do you think about migrating to pynvml everywhere? This one https://pypi.org/project/nvidia-ml-py/

@AlexeyKozhevin
Copy link
Contributor Author

Do you mean change nvidia_smi to pynvml everywhere?

@AlexeyKozhevin AlexeyKozhevin merged commit 33d1128 into master Jul 5, 2024
27 checks passed
@AlexeyKozhevin AlexeyKozhevin deleted the update_gpu_utils branch July 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyTsimfer SergeyTsimfer SergeyTsimfer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyKozhevin @SergeyTsimfer