plugins/spectrum_analyzer: Add cmake option to build it or not #352
Conversation
There was a problem hiding this comment.
Wondering, if we're not building and installing the plugin anymore how can the ifdef in identify() do anything?
The original problem I see is that there is no clean uninstall when a new OSC is build and installed.
So all residual plugin SOs will get loaded. the only way to prevent this is to clean the plugin folder. Or to update the plugin with this identify hack.
Makes sense. Initially I kept building the plugin but then I modified. I will make the changes. |
And by default exclude it from build. Signed-off-by: Dan Nechita <[email protected]>
dNechita
force-pushed
the
optionally-enable-spectrum-plugin
branch
from
843a56b to
4fdba24
Compare
| add_definitions(-DPLUGIN_SPECTRUM_ANALYZER) | ||
| endif() | ||
|
|
||
|
|
There was a problem hiding this comment.
I guess this option should be in the plugins specific CMakeLists file. Moreover, I would just not compile the library at all if the option is OFF. As it is the default value, I would remove the plugin from the list of plugins and just add it if (WITH_PLUGIN_SPECTRUM_ANALYZER)
There was a problem hiding this comment.
I did that initially but as Michael said we need to build the plugin. As for the option, I prefer all options to be at top level cmake.
There was a problem hiding this comment.
Cannot say I agree with that but fair enough...
IMO, I would just vote for the first option "clean the plugin folder"... Maybe adding an uninstall target? |
And by default exclude it from build.
Signed-off-by: Dan Nechita [email protected]