ad_gmsl2eth_sl: Rework assign_bd_address #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastmaier
requested review from
IuliaCMoldovan,
StancaPop,
LBFFilho,
acostina,
AndreiGrozav,
PopPaul2021 and
sarpadi
as code owners
|
RetriggerCI |
gastmaier
force-pushed
the
ad_gmsl2eth_sl-fix
branch
from
a3a0334
to
17e0827
Compare
sarpadi
reviewed
Sep 20, 2024
| adi_project_run ad_gmsl2eth_sl_k26 | ||
| reset_msg_config -id {Designutils 20-1280} -default_severity |
There was a problem hiding this comment.
Resetting after the synthesis, so it won't affect other projects.
There was a problem hiding this comment.
On the last commit, I remove the dangling IP instead, not requiring to downgrade this error message
Only provide objects to assign instead of providing a explicit target_address_space. Add port name to ad_mem_hpc0_interconnect. remove data width. Signed-off-by: Jorge Marques <[email protected]>
Infer address space of m_axi_dma after creating the intf xilinx.com:interface:aximm:1.0 Previously, would inherit from the inferred prior to ipx::remove_all_bus_interface [ipx::current_core] However, vivado shall infer other intf like analog.com:interface:if_xcvr_cm:1.0 as observed in the CI with the other libs/intfs in cache, and not infer the addr space at that point. Call adi_add_bus_clk once with all buses, to generate a single bus abstraction for the clk and rst signal, which caused issues with the association of the signals with the interfaces. Rename core_clk and core_rst to clk and rst. Remove eth_xcvr_gth_channel during the corundum IP build. Even though both eth_xcvr_gth_channel and eth_xcvr_gth_full are created by the corundum script, only the latter is used on the design at our configuration. Resolves Designutils 20-1280 critical warning Signed-off-by: Jorge Marques <[email protected]>
Signed-off-by: Jorge Marques <[email protected]>
gastmaier
force-pushed
the
ad_gmsl2eth_sl-fix
branch
from
b62d551
to
45d27e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Rework assign_bd_address to only provide objects to assign instead of providing a explicit target_address_space.
Aims to fix the error obtained on the CI:
I was not able to replicate the error locally.
Synthesized the changed project locally.
Remove duplicated content on doc page.
48c3dff fixes:
b62d551 fixes:
PR Type
PR Checklist