Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add new analytics variables for Navegg vendor #40194

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

hugocs1
Copy link
Contributor

@hugocs1 hugocs1 commented Oct 28, 2024

  • Adds new analytics variables for Navegg vendor, using URL variable substitutions.
  • Minor URL fix

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024

CLA assistant check
All committers have signed the CLA.

@erwinmombay
Copy link
Member

LGTM

@erwinmombay erwinmombay removed the request for review from caroqliu October 28, 2024 21:48
@erwinmombay
Copy link
Member

@hugocs1 could you get the failing tests to pass. will merge when green:

TOTAL: 1 FAILED, 2209 SUCCESS


1) test requests
     amp-analytics   vendor request tests analytics vendor: navegg
     Error: Vendor navegg, request pageview doesn't match. Expected value https://amp.navdmp.com/amp?aid=_client_id(navegg_id)_&url=_canonical_url_&ref=_document_referrer_&tit=_title_&lan=_browser_language_&acc=!account&wst=_wst_&wct=_wct_&wla=_wla_&v=7, last sent out value is https://amp.navdmp.com/amp?aid=_client_id(navegg_id)_&url=_canonical_url_&ref=_document_referrer_&tit=_title_&lan=_browser_language_&acc=!account&wst=!wst&wct=!wct&wla=!wla&v=7.

@hugocs1
Copy link
Contributor Author

hugocs1 commented Oct 29, 2024

@erwinmombay done!

@powerivq
Copy link
Contributor

@hugocs1 Suggest rebasing against the latest main branch to have the CI build fixed.

@hugocs1
Copy link
Contributor Author

hugocs1 commented Oct 29, 2024

@powerivq you mean this one? I tried but it says "This branch is not behind the upstream".

Maybe re-run the CI?

Thanks in advance!

@powerivq
Copy link
Contributor

@hugocs1 Sorry, please rebase now! It should have the fix.

@powerivq powerivq merged commit ac32751 into ampproject:main Oct 29, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants