♿ [amp-consent] fix: amp-consent iframe title for accessibility (#40047)

* fix: amp-consent iframe title for accesibility * fix: title origin * fix: lint issue * fix: move setAttribute with other setAttributes * fix: remove unnecessary title on iframe
ampproject · Sep 10, 2024 · 7cf605b · 7cf605b
1 parent f370d15
commit 7cf605b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/extensions/amp-consent/0.1/amp-consent.js b/extensions/amp-consent/0.1/amp-consent.js
@@ -1035,7 +1035,6 @@ export class AmpConsent extends AMP.BaseElement {
 
     // Set up the __tcfApiLocator window to signal postMessage support
     const iframe = this.element.ownerDocument.createElement('iframe');
-    iframe.setAttribute('title', this.element.title || 'Consent Banner');
     iframe.setAttribute('name', TCF_API_LOCATOR);
     iframe.setAttribute('aria-hidden', 'true');
     toggle(iframe, false);

diff --git a/extensions/amp-consent/0.1/consent-ui.js b/extensions/amp-consent/0.1/consent-ui.js
@@ -472,6 +472,7 @@ export class ConsentUI {
   createPromptIframe_(promptUISrc) {
     const iframe = this.parent_.ownerDocument.createElement('iframe');
     const sandbox = this.getSandboxAttribute_(promptUISrc);
+    iframe.setAttribute('title', this.parent_.title || 'Consent Banner');
     iframe.setAttribute('sandbox', sandbox);
     iframe.setAttribute('allow', IFRAME_ALLOWED_PERMISSIONS.join('; '));
     const {classList} = iframe;