Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try fix crash #117

Merged
merged 7 commits into from
Feb 13, 2024
Merged

fix: try fix crash #117

merged 7 commits into from
Feb 13, 2024

Conversation

qingzhuozhen
Copy link
Contributor

Summary

Try fix crash for
Crashed: com.apple.root.user-initiated-qos.cooperative
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000b358bfb30

Crashed: com.apple.root.user-initiated-qos.cooperative
0 libobjc.A.dylib 0x2c14 objc_retain + 16
1 libobjc.A.dylib 0x2c14 objc_retain_x0 + 16
2 libswiftCore.dylib 0x3fe05c objcRetainAndReturn(void*) + 32
3 BeReal 0xfe124c IdentifyInterceptor.isIdentityUpdated(_:) + 52 (IdentifyInterceptor.swift:52)

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@qingzhuozhen qingzhuozhen changed the base branch from main to release-1.1.x February 13, 2024 00:49
@qingzhuozhen qingzhuozhen changed the base branch from release-1.1.x to 1.1.x February 13, 2024 08:32
justin-fiedler
justin-fiedler reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change makes sense. Thanks @qingzhuozhen!

Mercy811
Mercy811 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Qingzhuo for fixing this. Why push to 1.1.x instead of main?

@qingzhuozhen qingzhuozhen changed the base branch from 1.1.x to main February 13, 2024 17:55
@qingzhuozhen qingzhuozhen marked this pull request as ready for review February 13, 2024 18:13
@qingzhuozhen qingzhuozhen merged commit 0536666 into main Feb 13, 2024
3 checks passed
@qingzhuozhen qingzhuozhen deleted the AMP-93068 branch February 13, 2024 18:24
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
@amplitude-sdk-bot
chore(release): 1.3.3 [skip ci]
0b77c2e 
## [1.3.3](v1.3.2...v1.3.3) (2024-02-13)

### Bug Fixes

* fix setOnce identify operation ([#119](#119)) ([6934c89](6934c89))
* try fix crash ([#117](#117)) ([0536666](0536666))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler left review comments

@Mercy811 Mercy811 Mercy811 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingzhuozhen @justin-fiedler @Mercy811