Added Australian and South African regions and an All Regions option #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Australian states and territories - Added South African provinces - Added option for displaying all sub-country regions in one dropdown menu - Moved logic for converting UK counties array into a named key array into libraries/regions.php to simplify plugin & fieldtype code.
I always miss those darn things...
|
Thanks for this man. I'm not going to merge this in quite yet however, because it bothers me that it's so specific, doesn't feel right. So far the add-in has provided info for entire continents, and has followed a certain logic in that way. Throwing South Africa into the mix is a curve ball, especially with the "all regions" option ... it feels too tailored for your specific use case. I'm going to think on this more, as it's sparked other ideas. The add-on is pretty stable, so you don't have to worry about your branch missing anything important (I know you had expressed reticence at maintaining a separate branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on Devot-ee.com, here's the updated add-on. Aside from added the 2 countries' states/territories/provinces, I moved the logic that converted the UK counties array into an associative array out from the fieldtype file, and put it in libraries/regions.php. I was having issues integrating the UK counties into the All Regions dropdown, and preparing the array ahead of time seemed like the best option.
Arbitrarily updated the version number from 2.1 to 2.2 - completely up to you.
I've done some basic testing and everything seems to work fine, both plugin and fieldtype.
Thanks for a great add-on!