Quote arguments with whitespace when printing command #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, printing baked commands doesn't represent the way arguments
are actually passed down to the program when values contain spaces.
The solution is to take such values in single quotes.
This is primarily to be able to copy printed commands
and run them in a shell.
BEFORE:
```python
>>> from sh import ls
>>> print(ls.bake('How I Met Your Mother'))
/bin/ls How I Met Your Mother
```
AFTER:
```python
>>> print(ls.bake('How I Met Your Mother'))
/bin/ls 'How I Met Your Mother'
```
Owner
|
Cool, thanks for the contribution. It may take a little while for it to land in the main branch, as I have some maintenance tasks to do before then. |
amoffat
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, printing baked commands doesn't represent the way arguments are actually passed down to the program when values contain spaces.
The solution is to take such values in single quotes.
This is primarily to be able to copy printed commands and run them in a shell.
BEFORE:
AFTER: