Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Commit

Permalink
Remove typos and printouts
Browse files Browse the repository at this point in the history
  • Loading branch information
lioneltrebuchon committed Nov 23, 2019
1 parent 12e674f commit f52e0bc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ feel free to fork and modify.
If you only want to use AMIV API, check out the online documentation
(There's a link in the github description above).

If you are an administrator and wish to get the AMIV API r`unning, keep reading!
If you are an administrator and wish to get the AMIV API running, keep reading!

If you are a developer looking to work on AMIV API, it's best to look at the
code directly. You can start with [bootstrap.py](amivapi/bootstrap.py),
Expand All @@ -36,7 +36,7 @@ You only need to install Docker, nothing else is required.

### Manual Installation for Development

For development, we recommend to **fork** the repository and install AMIV API
For development, we recommend to fork the repository and install AMIV API
manually.

First of all, we advise using a [virtual environment](https://docs.python.org/3/tutorial/venv.html).
Expand Down Expand Up @@ -76,7 +76,7 @@ password `amivapi`.
docker swarm init

# Create a network so that the api service can later be connected to the db
docker network create --driver overlay backend # Overlay so that it is representative of the real-life AMIV structure
docker network create --driver overlay backend

#
docker service create \
Expand Down Expand Up @@ -176,7 +176,7 @@ docker service create \
amiveth/amivapi amivapi cron --continuous

# To attach your command line to the docker instance, use
docker attach amivapi{...} # Use tab completion to find the name of the service
docker attach amivapi... # Use tab completion to find the name of the service

# As we run docker as a service, it restarts by itself even if you use docker kill
# To stop the service, use
Expand Down
2 changes: 1 addition & 1 deletion amivapi/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
# SMTP server defaults
API_MAIL = '[email protected]'
API_MAIL_SUBJECT = "[AMIV] {subject}"
SMTP_HOST = 'localhost' # None
SMTP_HOST = 'localhost' # None in case you want to accept that no mails get sent (local testing)
SMTP_PORT = 587
SMTP_TIMEOUT = 10

Expand Down
2 changes: 0 additions & 2 deletions amivapi/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ def mail(to, subject, text):
'receivers': to,
'text': text
})
elif app.config.get('DEBUG', False):
print('{}{}{}{}'.format(subject, sender, to, text))
elif config.SMTP_SERVER and config.SMTP_PORT:
msg = MIMEText(text)
msg['Subject'] = subject
Expand Down

0 comments on commit f52e0bc

Please sign in to comment.