fix: fixes log parser (#3398)

amir20 · Nov 16, 2024 · 80d502e · 80d502e
1 parent 56a2ab1
commit 80d502e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/internal/docker/logfmt.go b/internal/docker/logfmt.go
@@ -17,7 +17,7 @@ func ParseLogFmt(log string) (*orderedmap.OrderedMap[string, string], error) {
 		char := log[i]
 		if isKey {
 			if char == '=' {
-				if i == start {
+				if start >= i {
 					return nil, errors.New("invalid format: key is empty")
 				}
 				key = log[start:i]

diff --git a/internal/docker/logfmt_test.go b/internal/docker/logfmt_test.go
@@ -67,6 +67,12 @@ func TestParseLog(t *testing.T) {
 			),
 			wantErr: false,
 		},
+		{
+			name:    "Broken format with unexpected quotes",
+			log:     `key1=value"1"= key2="value2"`,
+			want:    nil,
+			wantErr: true,
+		},
 		{
 			name:    "Invalid log with unclosed quotes",
 			log:     "key1=\"value1 key2=value2",