Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install runtimes for packages installed by vcpkg #279

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FeignClaims
Copy link
Contributor

@FeignClaims FeignClaims commented Sep 11, 2024

resolves #261

resolves the vcpkg part of #261

@FeignClaims
Copy link
Contributor Author

FeignClaims commented Sep 11, 2024

~~Although this works well on my MacBook, it clearly needs to be tested with CI. However, I'm not sure how to write tests for it. Could you provide some suggestions? @aminya ~~

I choose to simply run the installed executable after installation.

@FeignClaims FeignClaims force-pushed the feat/install_runtimes_for_3rd_party branch 5 times, most recently from b4dbce0 to 757ec8d Compare September 12, 2024 10:22
@aminya
Copy link
Owner

aminya commented Sep 12, 2024

~~Although this works well on my MacBook, it clearly needs to be tested with CI. However, I'm not sure how to write tests for it. Could you provide some suggestions? @aminya ~~

I choose to simply run the installed executable after installation.

The tests should be good. We can also test it in a Docker container to make sure it runs in a clean system.
https://github.com/aminya/setup-cpp/blob/691fa792a8d5fd90d3669024745a5ab6572c80ad/dev/docker/examples/ubuntu-llvm.dockerfile#L9

@FeignClaims FeignClaims force-pushed the feat/install_runtimes_for_3rd_party branch 2 times, most recently from 15fe2fb to 6584b44 Compare September 18, 2024 03:36
@FeignClaims FeignClaims force-pushed the feat/install_runtimes_for_3rd_party branch 4 times, most recently from 00e144d to 0291688 Compare September 18, 2024 09:45
@FeignClaims
Copy link
Contributor Author

The vcpkg part is done.

Blocked by conan because it only supports runtime installation when it is invoked separately, as opposed to including conan_provider.cmake in CMakeLists.txt. conan-io/conan#17018

@FeignClaims
Copy link
Contributor Author

Blocked by conan because it only supports runtime installation when it is invoked separately, as opposed to including conan_provider.cmake in CMakeLists.txt. conan-io/conan#17018

According to the maintainer, conan might add the support in 2.9 (currently 2.7.1). Let's merge the vcpkg part first and merge the conan part once it gets supported.

@FeignClaims FeignClaims changed the title feat: install runtimes for packages installed by vcpkg or conan feat: install runtimes for packages installed by vcpkg Sep 18, 2024
@FeignClaims FeignClaims force-pushed the feat/install_runtimes_for_3rd_party branch from 0291688 to 9ccd37f Compare September 18, 2024 16:19
@FeignClaims FeignClaims marked this pull request as ready for review September 18, 2024 16:19
@FeignClaims
Copy link
Contributor Author

We can also test it in a Docker container to make sure it runs in a clean system.
https://github.com/aminya/setup-cpp/blob/691fa792a8d5fd90d3669024745a5ab6572c80ad/dev/docker/examples/ubuntu-llvm.dockerfile#L9

@aminya I'm not familiar enough with Docker and the test framework of this project, so I'm not able to write such a docker test. Could you finish this part of test? The rest is ready to merge btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: support installing imported targets for vcpkg and conan
2 participants