Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong string GLFW3_FOUND instead of correct glfw3_FOUND #53

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

traversaro
Copy link
Contributor

Follow up of #52 .

@traversaro traversaro requested a review from S-Dafarra as a code owner December 5, 2024 15:53
@traversaro
Copy link
Contributor Author

Without this fix, nothing is actually build, see the log from CI:

[1/8] Building CXX object _deps/glfont-build/CMakeFiles/GLFont.dir/src/FontAtlas.cpp.o
[2/8] Building CXX object _deps/glfont-build/CMakeFiles/GLFont.dir/src/GLFont.cpp.o
[3/8] Building CXX object _deps/glfont-build/CMakeFiles/GLFont.dir/src/GLUtils.cpp.o
[4/8] Building CXX object _deps/glfont-build/CMakeFiles/GLFont.dir/src/FTLabel.cpp.o
[5/8] Linking CXX shared library lib/libGLFont.so.0.0.1
[6/8] Creating library symlink lib/libGLFont.so
[7/8] Building CXX object src/vendor/stb/CMakeFiles/stb_image.dir/stb_image.cpp.o
[8/8] Linking CXX static library lib/libstb_image.a

while after this fix the device is installed.

@S-Dafarra S-Dafarra merged commit d333bf4 into main Dec 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants