Added methods to create the JoypadControlServer device internally #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
approved these changes
Nov 15, 2024
traversaro
reviewed
Nov 15, 2024
| { | ||
| yCError(OPENXRHEADSET) << "Could not open" << m_rpcPortName << " RPC port."; | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| { | ||
| std::lock_guard<std::mutex> lock(m_joypadServerMutex); | ||
| m_thisDevice.give(this, false); |
There was a problem hiding this comment.
Minor:
Suggested change
| m_thisDevice.give(this, false); | |
| m_thisDevice.give(this, /*own=*/false); |
See https://abseil.io/tips/94 for rationale.
There was a problem hiding this comment.
Whoops, I was too fast in merging
There was a problem hiding this comment.
No problem, I indeed commented after approving.
S-Dafarra
added a commit
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49. In particular, instead of relying on an external attach between the
OpenXRdevice and theJoypadControlServer, this modification allows running theJoypadControlServerinternally, and rebooting it every time it is needed.