Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated black version #11

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Updated black version #11

merged 1 commit into from
Feb 1, 2024

Conversation

S-Dafarra
Copy link
Member

black got updated and the style changed in many files

@S-Dafarra S-Dafarra self-assigned this Jan 26, 2024
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the first time that new black releases introduce changes that are not backward compatible. In the past, for lack of time, I just proceeded as you did in this PR (that at one point has to be done regardless).

However, this time I searched better in the documentation and I found out1 that black receives a major release every January, and they guarantee backward compatibility only within major releases. Therefore, once per year, if black is not pinned like black ~= 24.0, the style CI might start failing. cc @traversaro

Footnotes

  1. https://black.readthedocs.io/en/stable/the_black_code_style/index.html#stability-policy

@S-Dafarra
Copy link
Member Author

Thanks @diegoferigo.

Merging

@S-Dafarra S-Dafarra merged commit ec33e27 into main Feb 1, 2024
16 checks passed
@S-Dafarra S-Dafarra deleted the black_update branch February 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants