Apply suggestions from code review

Co-authored-by: Diego Ferigo <[email protected]>

src/hippopt/base/opti_solver.py

@@ -115,9 +115,10 @@ def _generate_objects_from_list(
             or list_of_optimization_objects
         )
 
-        output = copy.deepcopy(input_structure)
-        for i in range(len(output)):
-            output[i] = self.generate_optimization_objects(output[i])
+        output = [
+            self.generate_optimization_objects(copy.deepcopy(input_structure[i]))
+            for i in range(len(output))
+        ]
 
         self._variables = output
         return output
@@ -173,7 +174,7 @@ def _set_initial_guess_internal(
         self,
         initial_guess: TOptimizationObject,
         corresponding_variable: TOptimizationObject,
-    ):
+    ) -> None:
         for field in dataclasses.fields(initial_guess):
             has_storage_field = OptimizationObject.StorageTypeField in field.metadata
 
@@ -321,9 +322,10 @@ def _set_initial_guess_internal(
     def generate_optimization_objects(
         self, input_structure: TOptimizationObject | List[TOptimizationObject], **kwargs
     ) -> TOptimizationObject | List[TOptimizationObject]:
-        if isinstance(input_structure, OptimizationObject):
-            return self._generate_objects_from_instance(input_structure=input_structure)
-        return self._generate_objects_from_list(input_structure=input_structure)
+        return (
+            self._generate_objects_from_instance if isinstance(input_structure, OptimizationObject)
+            else self._generate_objects_from_instance
+            )(input_structure=input_structure)
 
     def get_optimization_objects(
         self,

src/hippopt/base/optimization_solver.py

@@ -20,7 +20,7 @@ def generate_optimization_objects(
     @abc.abstractmethod
     def set_initial_guess(
         self, initial_guess: TOptimizationObject | List[TOptimizationObject]
-    ):
+    ) -> None:
         pass
 
     @abc.abstractmethod
@@ -36,11 +36,11 @@ def get_cost_value(self) -> float | None:
         pass
 
     @abc.abstractmethod
-    def add_cost(self, input_cost: cs.MX):
+    def add_cost(self, input_cost: cs.MX) -> None:
         pass
 
     @abc.abstractmethod
-    def add_constraint(self, input_constraint: cs.MX):
+    def add_constraint(self, input_constraint: cs.MX) -> None:
         pass
 
     @abc.abstractmethod