Implement SerdeDiff for a few infallible container types #37
+195
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoobergs
pushed a commit
to jhoobergs/serde-diff
that referenced
this pull request
Jan 18, 2022
Taken from amethyst#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cow, Box, and Cell all have trivial implementations that should make it easy to support more downstream uses of SerdeDiff.
Rc, Arc, RefCell, and friends have either fallible read or write operations, so those are not implemented as those implementations would be opinionated, and I don't have an opinion on how that should be done.
Lastly,
'ain the derive macro is replaced by'sd, mimicking the'defrom Serde's Deserialize.