Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(node): remove eol node versions #363

Merged
merged 1 commit into from
Jan 7, 2025
Merged

ci(node): remove eol node versions #363

merged 1 commit into from
Jan 7, 2025

Conversation

code-forger
Copy link
Member

@code-forger code-forger commented Jan 7, 2025

This is non breaking as these versions of node are sunset

This also fixes the tests on windows, which are currently broken in the main branch

@code-forger code-forger requested a review from a team as a code owner January 7, 2025 12:27
@code-forger code-forger force-pushed the feat/remove-node branch 3 times, most recently from 4bde42e to 1e9fff0 Compare January 7, 2025 13:35
@code-forger
Copy link
Member Author

run checks

@@ -61,6 +61,7 @@ describe('OutdatedSnapshotReporter', () => {
cwd: tmpDir,
encoding: 'utf-8',
env: { ...process.env, ...environment },
shell: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-forger code-forger merged commit 5711e3d into main Jan 7, 2025
12 checks passed
@code-forger code-forger deleted the feat/remove-node branch January 7, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants