Skip to content

Commit

Permalink
Add in a comment explaining where Python3::Interpreter comes from. (#510
Browse files Browse the repository at this point in the history
)

This is a compromise between doing the very correct thing
(find_package(Python3) in ament_python_install_packge), and
not changing things unnecessarily.

Signed-off-by: Chris Lalancette <[email protected]>
  • Loading branch information
clalancette authored Feb 16, 2024
1 parent 6b310f5 commit dc3df2f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ament_cmake_python/cmake/ament_python_install_package.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ setup(
endif()
endif()

# Technically, we should call find_package(Python3) first to ensure that Python3::Interpreter
# is available. But we skip this here because this macro requires ament_cmake, and ament_cmake
# calls find_package(Python3) for us.
get_executable_path(python_interpreter Python3::Interpreter BUILD)

add_custom_target(
Expand Down

0 comments on commit dc3df2f

Please sign in to comment.