Introduce a switch to select yum or dnf to be used for yum-based distros #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so the build system can actually build RPMs
Removing the %{dist} dependency from the spec file and adding
a proper package manager switch now allows to use the rpmbuild
internal functionality `--with` and `--without` to switch
the package manager used.
The usage is:
rpmbuild -bb --with yum smart-restart.spec
to build for YUM based distros
or:
rpmbuild -vv -bb --without yum smart-restart.spec
for DNF based.
Since I am reworking the pkg manger switches anyways, I also
slightly modified the resulting tarball creation. The
`make sources` output now doesn't contain the release anymore.
bjoernd
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
smart-restartis only available for al2023 which uses dnf. This version adds a switch to useyumas well so we can shipsmart-restartfor al2 in a future release.The makefile already can handle both, dnf and yum. This change adds a proper switch to the
smart-restart.specfile so either the spec file automatically decides on the OS based on theamzn2macro, or can be overwritten using--without yum. Using this switch only changes the package manager, not the distro. The distro can still be overwritten using-D "dist .amzn2023"or-D "dist .amzn2".Example usage:
This will generate an RPM for the al2023 distro using yum (This will NOT WORK. No yum on al2023).