Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serial: migrate to lib.wiring components. #7

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jfng
Copy link
Member

@jfng jfng commented Nov 27, 2023

As a breaking change, divisor_bits must now be greater than or equal to bits_for(divisor).

As a breaking change, `divisor_bits` must now be greater than or equal
to `bits_for(divisor)`.
@jfng jfng requested a review from whitequark November 27, 2023 12:34
@whitequark
Copy link
Member

I'm a bit wary of merging this--we do need to define a (new, though arguably there wasn't one) process for adding peripherals to amaranth-stdio and that would likely change AsyncSerial a fair bit.

@jfng
Copy link
Member Author

jfng commented Nov 27, 2023

I'm a bit wary of merging this--we do need to define a (new, though arguably there wasn't one) process for adding peripherals to amaranth-stdio and that would likely change AsyncSerial a fair bit.

I also believe that AsyncSerial will see significant changes (i.e. be rewritten) as we figure out our strategy for -stdio.

The motivation of this PR is to make AsyncSerial useful for experimenting with component metadata and SoC peripherals; I don't really need it merged, but doing so would be convenient.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the caveat mentioned.

@whitequark whitequark added this pull request to the merge queue Nov 27, 2023
Merged via the queue into amaranth-lang:main with commit 21f44f5 Nov 27, 2023
1 of 2 checks passed
@jfng
Copy link
Member Author

jfng commented Nov 27, 2023

Thanks for reviewing!

@jfng jfng deleted the serial-lib-wiring branch November 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants