Adds support for templates when creating a new migration #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can now specify a template file when creating a migration
|
Have you found storing templates in your home folder useful? I would expect something like that to live in your repo. |
|
@amacneil that's a great question. I do think most of my templates end up in the repo eventually. It depends on if I am working with others. The home folder can be convenient as a generic place to hold templates that I would use across different projects. |
|
Is this still planned to be upstreamed? I would love to use this in a stable version of dbmate. |
|
No. Having templates stored outside of your code repo seems against the KISS approach of dbmate. You can also do this outside of dbmate easily by copy/pasting files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by Sqitch Templates
Concerns:
I set the default directory to
~/.config/dbmate/templatessimilar to sqitch. Should we consider different default paths based on the OS?There are potential issues with needing to escape characters passed in via the CLI as mentioned in the #439