-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid components #118
base: master
Are you sure you want to change the base?
Conversation
What is the source of this? |
It was set like this (and working) before you merged your api breaking PR. |
I just saw the DisplayNameComponent needs also a fix. EDIT: And there's even more to fix. |
The display_name compound tag is not nested in components, it's in the root.
Thanks, Are there any leftover mistakes? |
There's still more, e.g. some global variables in the CustomItemProperties class are not set when the corresponding component is applied, and other variables are only set local and never update the global variables, so the getter methods will always return the default values. Unfortunately I didn't have time to continue working on that, sorry... |
well, I don't care about those getters, since I was about to remove them. what I meant was are there any leftover component-related mistakes. |
No description provided.