-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Don't depend on tester's system timezone for success #8
base: master
Are you sure you want to change the base?
Conversation
- Org timestamps uses tester's timezone, so the ideal value should too - ts-format accepts %z just like format-time-string, so it's reasonable to expect it to support timezones. Add that into its ideal value.
Thanks.
Do you mean that this branch fixes one test and breaks another? |
I mean that it fixes the test, which exposes the fact that |
@alphapapa Can we merge this and #9? Currently emacs-ts build is broken on Guix, because of the #9. Tests do not work if you are on a different timezone anyway, so we won't break anything. WDYT? |
Sorry for the delay. See commits linked on #18. In this PR, adding |
Quoting myself:
Actually, that doesn't seem to work properly, because the |
ts-format
accepts "%z" just likeformat-time-string
, so it's reasonable to expect it to support timezones. Add that into its ideal value.This should fix #6.
This will make
ts-format
in its current form fail its test—I think that's justified, as it currently throws away the timestamp's timezone information and inserts the local timezone into its output.