Search URL bug fix #107
Merged
Search URL bug fix #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween v1 and v2 - not the page URLs - whoops
|
TimGJD
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search URL bug fix
We need to keep the BASE_URL as it is only the Search API URL that changes between v1 and v2. I had forgotten that we also use this when generating the full URL from the path in the content item that is returned in the search results. So, when I updated the test - it still passed, but should not have. Lesson - listen to your tests.
This change fixes that issue by introducing an API_BASE_URL and updating the API call. The test is reverted to a hard-coded string as this is a good check that the user will go to the correct URL.