Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings links #104

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Update settings links #104

merged 6 commits into from
Nov 8, 2024

Conversation

gclssvglx
Copy link
Collaborator

Update settings links

This change:

  • Redirects Help and feedback link from sub page to an external URL
  • Adds external links and analytics handlers for:
    • Help and feedback
    • Privacy policy
    • Accessibility statement
    • Terms and conditions

JIRA ticket(s)

Figma

Screenshots

Light Mode Dark Mode
settings-day settings-night

Analytics events

Firebase event sent with: Bundle[{external=true, language=en, url=https://www.gov.uk, text=HelpAndFeedback, type=SettingsItem}]
Firebase event sent with: Bundle[{external=true, language=en, url=https://www.gov.uk/government/publications/govuk-app-privacy-notice-how-we-use-your-data, text=PrivacyPolicy, type=SettingsItem}]
Firebase event sent with: Bundle[{external=true, language=en, url=https://www.gov.uk/government/publications/accessibility-statement-for-the-govuk-app, text=AccessibilityStatement, type=SettingsItem}]
Firebase event sent with: Bundle[{external=true, language=en, url=http://www.gov.uk/government/publications/govuk-app-terms-and-conditions, text=TermsAndConditions, type=SettingsItem}]

Notes 🎶

  • The URL for Help and feedback is currently set to the GOV.UK home page. The actual URL is pending completion of User Feedback Form
  • All other URLs are supposedly correct, but pending those pages being published on GOV.UK.
  • All URLs and analytic event names are now stored - once - in the Settings BuildConfig.

@gclssvglx gclssvglx requested a review from a team as a code owner November 7, 2024 14:38
Copy link

sonarcloud bot commented Nov 7, 2024

@gclssvglx gclssvglx merged commit 680d199 into develop Nov 8, 2024
2 checks passed
@gclssvglx gclssvglx deleted the update-settings-links branch November 8, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants