Deprecate govuk/all.scss and only reference govuk/index.scss internally

[owenatgov]

A continuation of #4955 to deprecate the root all sass file as well as the all files in the layers. Additionally removes all references to all.scss internally.

Part of #4988 but doesn't resolve it as we also need to update the Frontend docs.

[github-actions]

📋 Stats

File sizes

File	Size
dist/govuk-frontend-development.min.css	118.41 KiB
dist/govuk-frontend-development.min.js	42.7 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js	92.79 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs	87.12 KiB
packages/govuk-frontend/dist/govuk/all.mjs	1.25 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs	1.74 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css	118.4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js	42.69 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs	5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs	7.13 KiB

Modules

File	Size (bundled)	Size (minified)
all.mjs	82.57 KiB	40.4 KiB
accordion.mjs	26.58 KiB	13.41 KiB
button.mjs	9.09 KiB	3.78 KiB
character-count.mjs	25.39 KiB	10.9 KiB
checkboxes.mjs	7.81 KiB	3.42 KiB
error-summary.mjs	10.99 KiB	4.54 KiB
exit-this-page.mjs	20.2 KiB	10.34 KiB
header.mjs	6.46 KiB	3.22 KiB
notification-banner.mjs	9.35 KiB	3.7 KiB
password-input.mjs	18.24 KiB	8.33 KiB
radios.mjs	6.81 KiB	2.98 KiB
service-navigation.mjs	6.44 KiB	3.26 KiB
skip-link.mjs	6.4 KiB	2.76 KiB
tabs.mjs	12.04 KiB	6.67 KiB

View stats and visualisations on the review app

---

Action run for 1720493

[github-actions]

Other changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/all.scss b/packages/govuk-frontend/dist/govuk/all.scss
index 1d57cf86e..b29cb4977 100644
--- a/packages/govuk-frontend/dist/govuk/all.scss
+++ b/packages/govuk-frontend/dist/govuk/all.scss
@@ -1,3 +1,9 @@
 @import "index";
 
+@include _warning(
+  "import-using-all",
+  "Importing using 'govuk/all' is deprecated. Update your import statement to import 'govuk/index'.",
+  $silence-further-warnings: false
+);
+
 /*# sourceMappingURL=all.scss.map */

---

Action run for 1720493

[romaricpascal]

Blimey, that was a lot of places we were using that all.scss file, thanks for being super thorough, as always 🙌🏻 .

Only two minor comments on the update, thanks. I think it also needs a CHANGELOG entry announcing the deprecation 😊

[owenatgov]

I've added a changelog that mostly replicates what was written for when we deprecated the all files in the layers.

[romaricpascal]

Cheers for the CHANGELOG and taking onboard the suggestions 🙌🏻 I've pulled @calvin-lau-sig7 and @seaemsi to ask when they prefer to review the content, and noticed two little things in the code that raised questions (and that I may have missed in my initial review).

[romaricpascal]

@calvin-lau-sig7 @seaemsi Would you prefer updating this bit as part of this PR or during the release process? Let us know what work best with your current workload 😊

[romaricpascal]

suggestion Could we use this as an opportunity to remind that people should move to use Dart Sass rather than stay on LibSass or Ruby Sass or would that be too distracting?

Suggested change

	You do not need `/index` at the end of each import path if you’re using Dart Sass, LibSass 3.6.0 or higher, or Ruby Sass 3.6.0 or higher.
	You do not need `/index` at the end of each import path if you’re using Dart Sass (as well as LibSass 3.6.0 or higher, or Ruby Sass 3.6.0 or higher, though we recommend you migrate to Dart Sass if you're using LibSass or Ruby Sass as they are both deprecated).

Or maybe by just silencing that you have benefits in the deprecated Sass compilers?

Suggested change

	You do not need `/index` at the end of each import path if you’re using Dart Sass, LibSass 3.6.0 or higher, or Ruby Sass 3.6.0 or higher.
	You do not need `/index` at the end of each import path if you’re using Dart Sass.

[owenatgov]

I think I prefer your second suggestion. Suggestion via erasure. It delivers the message (that messag being 'use Dart Sass') more subtly but also more efficiently. I'll wait and see what the content folks say.

[romaricpascal]

All good code-wise, thanks for making the changes. Let's see how we prefer handling the changelog 😊