-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move component attributes into govukAttributes()
#4770
Open
colinrotherham
wants to merge
2
commits into
main
Choose a base branch
from
component-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4770
February 16, 2024 15:25
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 2affb93 |
colinrotherham
force-pushed
the
component-attributes
branch
from
February 16, 2024 15:46
a85f8b1
to
a8be40b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4770
February 16, 2024 15:47
Inactive
colinrotherham
force-pushed
the
component-attributes
branch
from
February 16, 2024 15:53
a8be40b
to
9501e02
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4770
February 16, 2024 15:54
Inactive
colinrotherham
force-pushed
the
component-attributes
branch
from
February 19, 2024 18:48
9501e02
to
3220cb5
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4770
February 19, 2024 18:48
Inactive
colinrotherham
force-pushed
the
component-attributes
branch
from
February 27, 2024 10:54
3220cb5
to
fe1628d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4770
February 27, 2024 10:54
Inactive
colinrotherham
force-pushed
the
component-attributes
branch
from
March 8, 2024 15:50
fe1628d
to
2affb93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress PR to move key attributes into
govukAttributes()
Due to improved checks for
null
,undefined
or empty""
this closes #4669To help discuss, I've picked these components so far:
Character countb93ef7b