Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure stat comments only run on PRs #4121

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

domoscargin
Copy link
Contributor

Stat comments are part of the tests workflow, which runs on pulls and pushes, but should only run on PRs.

This should hopefully make sure that happens.

@domoscargin domoscargin requested a review from a team as a code owner August 24, 2023 10:38
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4121 August 24, 2023 10:39 Inactive
@github-actions
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.6.0.min.css 118.07 KiB
dist/govuk-frontend-4.6.0.min.js 47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css 79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 72.35 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 67.96 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.91 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 34.31 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.83 KiB

Modules

File Size
all.mjs 64.5 KiB
components/accordion/accordion.mjs 20.86 KiB
components/button/button.mjs 3.67 KiB
components/character-count/character-count.mjs 20.46 KiB
components/checkboxes/checkboxes.mjs 4.37 KiB
components/error-summary/error-summary.mjs 4.96 KiB
components/exit-this-page/exit-this-page.mjs 15.42 KiB
components/header/header.mjs 2.3 KiB
components/notification-banner/notification-banner.mjs 3.5 KiB
components/radios/radios.mjs 3.37 KiB
components/skip-link/skip-link.mjs 2.12 KiB
components/tabs/tabs.mjs 8.04 KiB

View stats and visualisations on the review app


Action run for ab2032d

Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This manual run was correctly skipped:
https://github.com/alphagov/govuk-frontend/actions/runs/5962662757

Would be nice for non-PRs runs to write to GitHub workflow status (not PR comment) but one for another day!

@domoscargin domoscargin merged commit c8eb86f into main Aug 24, 2023
@domoscargin domoscargin deleted the bk-run-stats-on-pr-only branch August 24, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants