-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stats comment to Pull Requests #4039
Conversation
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 7ee4596 |
@domoscargin Love seeing these stats appearing 😍 |
Hmm, application error on the deployment... Looks like I'll have a look at rejigging things a bit. edit: Done. I've moved |
0e37de3
to
1a78268
Compare
fa28279
to
3ce997f
Compare
3ce997f
to
31af39d
Compare
31af39d
to
b5e29c2
Compare
b5e29c2
to
28fff27
Compare
c7d3e8f
to
5d5fa3b
Compare
5d5fa3b
to
bb41868
Compare
858e504
to
623d261
Compare
081f58b
to
0032a78
Compare
0032a78
to
3cdad38
Compare
@colinrotherham, I've implemented your changes and all looks good. I've also cleaned up the commit list, because it was getting messy. |
2860f1e
to
e4cbcb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ace, good to have this merged
Can you double check package versions? Think some had updated
/** | ||
* @typedef {object} StatComment | ||
* @property {string} titleText - The title of the comment | ||
* @property {string} markerText - The marker to identify the comment | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but we could share (or rename) the DiffComment
type to avoid a new one
The workspace path could satisfy path
to stop any warnings
await commentStats({ github, context, commit }, issueNumber, {
path: '${{ github.workspace }}',
titleText: ':clipboard: Stats',
markerText: 'stats'
})
e4cbcb9
to
7ee4596
Compare
Closes #3282
Adds file sizes for key files, and a module breakdown summary in a comment on all PRs.