Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text input ignoring 0 as value #4669

Closed
dwp-dmitri-algazin opened this issue Jan 23, 2024 · 1 comment · May be fixed by #4770
Closed

Text input ignoring 0 as value #4669

dwp-dmitri-algazin opened this issue Jan 23, 2024 · 1 comment · May be fixed by #4770
Assignees
@patrickpatrickpatrick
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) nunjucks text input
Milestone
5.4.0

Comments

@dwp-dmitri-algazin
Copy link

Description of the issue

If 0 (zero) is a valid field value, govukInput() ignores it, because of this if condition:

govuk-frontend/packages/govuk-frontend/src/govuk/components/input/template.njk

Line 52 in 87d7633

{%- if params.value %} value="{{ params.value }}"{% endif %}

As we know from JavaScript, if ( 0 ) returns false, not true

Steps to reproduce the issue

Create govukInput with 0 value

Actual vs expected behaviour

I would expect to see mu input with value 0 in it

Environment (where applicable)

we use DWP Casa framework with latest GOV.UK Frontend Version: 5.0.0

  • Operating system: any
  • Browser: any
  • Browser version: any
  • GOV.UK Frontend Version: 5.0.0

when zero is a number ( 0 )

Screenshot 2024-01-23 at 17 14 21

when zero is a string ( '0' )

Screenshot 2024-01-23 at 17 10 50
@dwp-dmitri-algazin dwp-dmitri-algazin added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Jan 23, 2024
@github-actions GitHub Actions
Copy link

Uh oh! @dwp-dmitri-algazin, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@36degrees 36degrees added nunjucks text input and removed awaiting triage Needs triaging by team labels Jan 23, 2024
@colinrotherham colinrotherham self-assigned this Feb 16, 2024
@colinrotherham colinrotherham moved this to Needs review 🔍 in GOV.UK Design System cycle board Feb 16, 2024
@colinrotherham colinrotherham mentioned this issue Feb 16, 2024
Open
@36degrees 36degrees mentioned this issue Feb 22, 2024
Open
@colinrotherham colinrotherham removed their assignment Mar 10, 2024
@patrickpatrickpatrick patrickpatrickpatrick self-assigned this Apr 11, 2024
@patrickpatrickpatrick patrickpatrickpatrick moved this from Needs review 🔍 to In progress 📝 in GOV.UK Design System cycle board Apr 11, 2024
Merged
patrickpatrickpatrick added a commit that referenced this issue May 2, 2024
@patrickpatrickpatrick
Input component 0 value fix
06bd485 
Fixes #4669. Input component now uses govukAttributes macro to validate
and format attributes. Test and example added for edge case outlined in
issue #4669.
patrickpatrickpatrick added a commit that referenced this issue May 2, 2024
@patrickpatrickpatrick @colinrotherham
Input component 0 value fix
013fa29 
Fixes #4669. Input component now uses govukAttributes macro to validate
and format attributes. Test and example added for edge case outlined in
issue #4669.

Co-authored-by: Colin Rotherham <[email protected]>
patrickpatrickpatrick added a commit that referenced this issue May 2, 2024
@patrickpatrickpatrick @colinrotherham
Input component 0 value fix
51d1eb4 
Fixes #4669. Input component now uses govukAttributes macro to validate
and format attributes. Test and example added for edge case outlined in
issue #4669.

Co-authored-by: Colin Rotherham <[email protected]>
patrickpatrickpatrick added a commit that referenced this issue May 2, 2024
@patrickpatrickpatrick @colinrotherham
Input component 0 value fix
dfe5380 
Fixes #4669. Input component now uses govukAttributes macro to validate
and format attributes. Test and example added for edge case outlined in
issue #4669.

Co-authored-by: Colin Rotherham <[email protected]>
patrickpatrickpatrick added a commit that referenced this issue May 7, 2024
@patrickpatrickpatrick @colinrotherham
Fix input value not being set if the value was '0'
01df7cd 
Fixes #4669. Input component now uses govukAttributes macro to validate
and format attributes. Test and example added for edge case outlined in
issue #4669.

Co-authored-by: Colin Rotherham <[email protected]>
@patrickpatrickpatrick patrickpatrickpatrick moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board May 7, 2024
patrickpatrickpatrick added a commit that referenced this issue May 9, 2024
@patrickpatrickpatrick @colinrotherham
Fix input value not being set if the value was '0'
bfb1a8f 
Fixes #4669. Input component now uses govukAttributes macro to validate
and format attributes. Test and example added for edge case outlined in
issue #4669.

Co-authored-by: Colin Rotherham <[email protected]>
patrickpatrickpatrick added a commit that referenced this issue May 9, 2024
@patrickpatrickpatrick @colinrotherham
Fix input value not being set if the value was '0'
686a087 
Fixes #4669. Input component now uses govukAttributes macro to validate
and format attributes. Test and example added for edge case outlined in
issue #4669.

Co-authored-by: Colin Rotherham <[email protected]>
@36degrees 36degrees added this to the [next] milestone May 9, 2024
@36degrees 36degrees moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board May 9, 2024
@36degrees 36degrees moved this from Done 🏁 to Ready to release 🚀 in GOV.UK Design System cycle board May 9, 2024
36degrees pushed a commit that referenced this issue May 15, 2024
@patrickpatrickpatrick @colinrotherham
Fix input value not being set if the value was '0'
1b0e8d1 
Fixes #4669. Input component now uses govukAttributes macro to validate
and format attributes. Test and example added for edge case outlined in
issue #4669.

Co-authored-by: Colin Rotherham <[email protected]>
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickpatrickpatrick patrickpatrickpatrick

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) nunjucks text input
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
5.4.0
Development

Successfully merging a pull request may close this issue.

[WIP] Move component attributes into govukAttributes() alphagov/govuk-frontend
4 participants
@36degrees @colinrotherham @patrickpatrickpatrick @dwp-dmitri-algazin