Skip to content

Commit

Permalink
Upgrade test for deprecated LibSass to node-sass@5
Browse files Browse the repository at this point in the history
This is the first version that can be installed on Github Actions runner without failing thanks to it introducing support for Python 3.

https://github.com/sass/node-sass/releases/tag/v5.0.0

Co-authored-by: Brett Kyle <[email protected]>
Co-authored-by: Owen Jones <[email protected]>
  • Loading branch information
3 people committed Nov 21, 2024
1 parent 3c8fec3 commit 04b90a4
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/sass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@ jobs:
run: |
! grep "\$govuk-" .tmp/all.css
# Node Sass v3.7.0 = LibSass v3.5.0
# Node Sass v5.0.0 = LibSass v3.5.5
lib-sass:
name: LibSass v3.5.0 (deprecated)
name: LibSass v3.5.5 (deprecated)
runs-on: ubuntu-latest

steps:
Expand All @@ -93,11 +93,15 @@ jobs:
uses: actions/[email protected]
with:
cache: npm
node-version: 6 # Node.js 6 supported by Node Sass v3.7.0
# Node.js 15 is required for the stable support of ES Module
# used when installing `node-sass`
node-version: 15

- name: Install package
# Sass 5.0.0 is the first version that supports Python 3
# and as such can be built on a GitHub Actions runner
run: |
npm install -g node-sass@v3.7.0
npm install -g node-sass@v5.0.0
node-sass --version
- name: Run command
Expand Down

0 comments on commit 04b90a4

Please sign in to comment.