Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat search results metadata to be more verbose #4290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

owenatgov
Copy link
Contributor

Just a draft at the moment. Full description coming soon

Copy link

netlify bot commented Nov 8, 2024

You can preview this change here:

Name Link
🔨 Latest commit 5f6b3ec
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/673381d0e896e90008239a54
😎 Deploy Preview https://deploy-preview-4290--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@calvin-lau-sig7
Copy link
Contributor

Here's my thinking for showing the results:

  • [Page] in [section]
  • [Heading], part of [page] in section]

@owenatgov
Copy link
Contributor Author

I ran accessibility testing against this PR and the 3 other PRs with different methods to visually and programatically highlight the pages and sections in metadata:

My general analysis of these findings: None of these 3 methods really make a difference to identification of sections and pages specifically for those words in screen reader audio. Quotes start imacting readout, notably for JAWS and Talkback, but not for any other screen readers.

From off-github chats, we're starting to lean towards not having any extra indiciation as the content of the readout provides context. On the other hand it gives us some freedom to experiment since at least these techniques don't impact screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants