Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new form to seeds for end to end testing #629

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alice-carr
Copy link
Contributor

What problem does this pull request solve?

we're adding a new end to end test that will test forms with a submission type of s3. There's no front end way to set a form to a type of s3, so we can't create the form in the e2e tests. Instead, when testing locally, we will use this new seeded form.

Trello card

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

we're adding a new end to end test that will test forms with a submission type of s3.
There's no front end way to set a form  to a type of s3, so we can't create the form in the e2e tests.
Instead, when testing locally, we will use this new seeded form.
Copy link

sonarcloud bot commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant