-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Adopt the experimental free function extension #2073
base: develop
Are you sure you want to change the base?
[SYCL] Adopt the experimental free function extension #2073
Conversation
497128d
to
5ea8f82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Here is a further suggestion:
Access the current nd_item via a free function instead of storing it as a data member of the various SYCL accelerator base classes.
5ea8f82
to
39d86c6
Compare
I will keep this as a draft while we check the impact on the performance. |
The performance does not change:
However, since this feature is still experimental and there is another one similar to it as proposed, maybe it's better to wait a bit and see if the extension gets modified. The tests done with pixeltrack-standalone@dcf2898. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Feel free to convert this into a real PR.
Access the current nd_item via a free function instead of storing it as a data member of the various SYCL accelerator base classes.