Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally implement std::error::Error for Error #39

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Aug 5, 2024

This makes error handling easier when std is available, but is guarded behind a new feature std, to avoid pulling in the dependency for users who don't want it.

Also implemented Display, Debug, Clone and Eq.

Copy link
Owner

@almusil almusil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the PR I have two comments.

Cargo.toml Outdated Show resolved Hide resolved
src/error.rs Show resolved Hide resolved
@almusil almusil merged commit d59ac13 into almusil:master Aug 8, 2024
3 checks passed
@qwandor qwandor deleted the std_error branch August 8, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants