Fixed test-results missing in case of test parallel execution [allure-scalatest] (fixes #945) #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dm-test
force-pushed
the
allure-scalatest-fix-parallel-execution
branch
from
0e7d782
to
5bc9e81
Compare
baev
approved these changes
Aug 15, 2023
|
@dm-test thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #945
Context
When you run tests in parallel with scalatest, you can miss some allure-results files. It caused by different from java frameworks (testng, junit) test threads behaviours in scalatest. Allure-scalatest knows about this point, but it was a bug in stopTest behaviour: this method worked as in java-style and tried to get UUID of test case from internal allure thread holder class. In multithreading launches in scalatest threads sometimes have changed and we can't find UUID by thread in allure internal threadlocal storage. So in such cases we can't write a test result to file.
Checklist