Skip to content

perf: avoid cloning transactions in TxTracer #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nkysg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: avoid cloning transactions in TxTracer #276

nkysg wants to merge 1 commit into from
+20 −4

Conversation

@nkysg
Copy link

@nkysg nkysg commented Feb 2, 2026 •
edited
Loading

Motivation

  • Replace T: IntoTxEnv + Clone bound with for<'a> &'a T: IntoTxEnv
    in trace_many/try_trace_many methods
  • Pass transaction by reference instead of cloning in TracerIter::next
  • Add ToTxEnv implementations for &TxEnv and &OpTransaction

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@nkysg nkysg requested review from klkvr and mattsse as code owners February 2, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nkysg