fix: supplement fields in cli and profile credentials #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 94.97% 95.37% +0.40%
==========================================
Files 66 66
Lines 5391 5454 +63
Branches 231 234 +3
==========================================
+ Hits 5120 5202 +82
+ Misses 223 204 -19
Partials 48 48 ☔ View full report in Codecov by Sentry. |
yndu13
reviewed
Nov 5, 2024
| @@ -19,7 +19,7 @@ namespace Aliyun.Credentials.Provider | |||
| /// <item><description>Windows: C:\Users\USER_NAME\.aliyun\config.json</description></item> | |||
| /// </list> | |||
| /// </summary> | |||
| internal class CLIProfileCredentialsProvider : IAlibabaCloudCredentialsProvider | |||
| public class CLIProfileCredentialsProvider : IAlibabaCloudCredentialsProvider | |||
| @@ -158,6 +165,9 @@ internal IAlibabaCloudCredentialsProvider ReloadCredentialsProvider(Config confi | |||
| .RoleSessionName(profile.GetRoleSessionName()) | |||
| .OIDCProviderArn(profile.GetOidcProviderArn()) | |||
| .OIDCTokenFilePath(profile.GetOidcTokenFile()) | |||
| .StsRegionId(profile.GetStsRegionId()) | |||
| .Policy(profile.GetPolicy()) | |||
| .EnableVpc(profile.GetEnableVpc() ?? false) | |||
| .Build(); | |||
There was a problem hiding this comment.
这里不能带默认值false，为空的话，需要根据环境变量ALIBABA_CLOUD_ENABLE_VPC_ENDPOINT来判断
| @@ -166,6 +176,10 @@ internal IAlibabaCloudCredentialsProvider ReloadCredentialsProvider(Config confi | |||
| .RoleArn(profile.GetRoleArn()) | |||
| .DurationSeconds(profile.GetDurationSeconds() ?? 3600) | |||
| .RoleSessionName(profile.GetRoleSessionName()) | |||
| .StsRegionId(profile.GetStsRegionId()) | |||
| .EnableVpc(profile.GetEnableVpc() ?? false) | |||
| .Policy(profile.GetPolicy()) | |||
| @@ -172,6 +175,9 @@ public CredentialModel GetSTSAssumeRoleSessionCredentials(Dictionary<string, str | |||
| .RoleArn(roleArn) | |||
| .RegionId(regionId) | |||
| .Policy(policy) | |||
| .StsRegionId(stsRegionId) | |||
| .EnableVpc(enableVpc == "true") | |||
There was a problem hiding this comment.
enableVpc如果为空，这里是不是就设置成false了
| @@ -323,6 +331,8 @@ public async Task<CredentialModel> GetSTSOIDCRoleSessionCredentialsAsync(Diction | |||
| .RoleSessionName(roleSessionName) | |||
| .RegionId(regionId) | |||
| .Policy(policy) | |||
| .StsRegionId(stsRegionId) | |||
| .EnableVpc(enableVpc == "true") | |||
PanPanZou
force-pushed
the
file-credentials
branch
9 times, most recently
from
537ae90
to
9b3e148
Compare
PanPanZou
force-pushed
the
file-credentials
branch
from
9b3e148
to
6e48607
Compare
yndu13
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.