Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DisableCollectionNullChecks and EntityFrameworkCompatibilityLayer in the mapper configuration #239

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

alirezanet
Copy link
Owner

Description

Add DisableCollectionNullChecks and EntityFrameworkCompatibilityLayer in the mapper configuration

Fixes #238

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Copy link

what-the-diff bot commented Dec 2, 2024

PR Summary

  • Modified access level of certain methods
    The methods in BaseQueryBuilder.cs and LinqQueryBuilder.cs were originally only available within their respective classes and could not be altered or called outside them. The access level has now been changed from private static to private which allows for more flexibility within the code.

  • Improved null check logic
    The changes now ensure that null check logic uses properties from mapper.Configuration instead of GridifyGlobalConfiguration. This enhancement will help for better handling of null values, specifically when dealing with DisableCollectionNullChecks and EntityFrameworkCompatibilityLayer.

  • Addition of new property for null checks configuration
    A new property DisableCollectionNullChecks has been added to GridifyMapperConfiguration. This allows users more control in regulating null checks on nested collections.

  • Clarified case sensitivity comments
    The comments regarding case sensitivity in different files were updated for better understanding. This clearly mentions that string comparison is, by default, case-sensitive.

  • Added a new test case
    A new test case has been added in GridifyExtensionsShould.cs. This test validates that by disabling null checks, automatic null checks in the mapper configuration can be prevented. This helps in ensuring that the new feature works as expected.

@alirezanet alirezanet merged commit b4bdc29 into master Dec 2, 2024
3 checks passed
@alirezanet alirezanet deleted the Issue238 branch December 2, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure DisableNullChecks at query and/or mapper level
1 participant