fix async-simple no discard when call spinlock::coScopedLock (#884)

* fix async-simple no discard when call spinlock::coScopedLock * remove useless header
alibaba · Jan 20, 2025 · c4fc58e · c4fc58e
1 parent 45d5061
commit c4fc58e
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/include/ylt/thirdparty/async_simple/coro/SpinLock.h b/include/ylt/thirdparty/async_simple/coro/SpinLock.h
@@ -60,11 +60,14 @@ class SpinLock {
         }
     }
 
-    void unlock() noexcept { _locked.store(false, std::memory_order_release); }
+    void unlock() noexcept {
+      assert(_locked.load(std::memory_order_acquire) == true);
+      _locked.store(false, std::memory_order_release);
+    }
 
-    Lazy<std::unique_lock<SpinLock>> coScopedLock() {
-        co_await coLock();
-        co_return std::unique_lock<SpinLock>{*this, std::adopt_lock};
+    [[nodiscard]] Lazy<std::unique_lock<SpinLock>> coScopedLock() {
+      co_await coLock();
+      co_return std::unique_lock<SpinLock>{*this, std::adopt_lock};
     }
 
 private: