fix: fp8_fmha_crash #512
Open
fix: fp8_fmha_crash #512
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash related to FP8 data type handling in ROCm FMHA (Fused Multi-Head Attention) operations. The fix introduces a new function getFmhaDataTypeStr that maps TYPE_FP8_E4M3 to "fp8bf16" instead of "fp8", which is the correct data type string expected by the CK (Composable Kernel) library.
- Adds a new
getFmhaDataTypeStrfunction specifically for FMHA operations that correctly maps FP8 to "fp8bf16" - Replaces all calls to
getDataTypeStrwithgetFmhaDataTypeStrin the three FMHA methods:runCKFmha,runCKFmhaV2, andrunCKFmhaMLA
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhiqchen-amd
force-pushed
the
zhaoan/fix_fp8_fmha_crash
branch
from
52e636c to
13fa82f
Compare
yuzho-amd
force-pushed
the
zhaoan/fix_fp8_fmha_crash
branch
from
13fa82f to
321fce8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: fp8_fmha_crash