-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Makefile #269
base: main
Are you sure you want to change the base?
Update Makefile #269
Conversation
update makefile version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 80.02% 80.02%
=======================================
Files 23 23
Lines 976 976
=======================================
Hits 781 781
Misses 156 156
Partials 39 39 ☔ View full report in Codecov by Sentry. |
@@ -15,7 +15,7 @@ | |||
#------------------------------------------------------------------------------- | |||
# General build options | |||
# Change this parameter while releasing | |||
MAIN_VERSION := 0.4.0 | |||
MAIN_VERSION := 0.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAIN_VERSION := 0.6.0 | |
MAIN_VERSION := $(shell git describe --tags `git rev-list --tags --max-count=1` | sed 's/^v//') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is is correct when we release a new version? For example if we are going to release v0.7.0, there is no v0.7.0 tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we always 1) push new tag 2) make all 3) draft new release, is there any unexpected workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually do that at the same time
You mean 1) create new tag on github 2) build from un-taged latest commit on local 3) upload artifacts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually do that at the same time
You mean 1) create new tag on github 2) build from un-taged latest commit on local 3) upload artifacts?
- build from un-taged latest commit on local and upload artifacts 2. create new tag on github and release at the same time
For the packager, it should be clear which version to package. |
+1 |
update makefile version