-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return all subscriber when ip or port is null. #13008
base: develop
Are you sure you want to change the base?
Conversation
…r when ip or port is null.
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13008 +/- ##
=============================================
+ Coverage 72.27% 72.31% +0.03%
- Complexity 9998 10004 +6
=============================================
Files 1309 1309
Lines 41991 41993 +2
Branches 4405 4407 +2
=============================================
+ Hits 30350 30366 +16
+ Misses 9516 9501 -15
- Partials 2125 2126 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
…r when ip or port is null.
|
Where is the new params? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new params to judge whether filter all subs when ip or port is null.
Ok
Em qui., 2 de jan. de 2025, 23:45, zhouchunhai ***@***.***>
escreveu:
… I think there is no need to add a new param. As described in the API doc,
when ip or port is null, it should return al subs.
image.png (view on web)
<https://github.com/user-attachments/assets/61737a2f-66a3-4687-8ac5-6fb84f32a656>
—
Reply to this email directly, view it on GitHub
<#13008 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4MT7RECDWINPKPZHCAPQQL2IX2TLAVCNFSM6AAAAABUPO67NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYGYZDQNZQGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
OK, please help add some unit tests. |
Ok
Em seg., 6 de jan. de 2025, 04:29, 杨翊 SionYang ***@***.***>
escreveu:
… OK, please help add some unit tests.
—
Reply to this email directly, view it on GitHub
<#13008 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4MT7RCGGZTMRIWAI2WMP4L2JIWGJAVCNFSM6AAAAABUPO67NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZSGQ3DENBXHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
|
Add a new param to support return all subscriber when ip or port is null.