Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE alibaba#12769] bug fix: Nacos(with Derby) incorrectly removes config history that has not exceeded the retention day setting. #12797

Closed
wants to merge 1 commit into from

Conversation

Melod-YI
Copy link

What is the purpose of the change

For #12769

Fix Nacos(with Derby) incorrectly removes config history that has not exceeded the retention day setting.

Brief changelog

修改了derby数据库的清理配置历史记录的sql。
使用nid主键清理。

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…config history that has not exceeded the retention day setting.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


xiongdingbo 00456851 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.63%. Comparing base (4334cd1) to head (6ac4d1b).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12797      +/-   ##
=============================================
- Coverage      72.63%   72.63%   -0.01%     
+ Complexity      9804     9802       -2     
=============================================
  Files           1278     1278              
  Lines          41015    41015              
  Branches        4330     4330              
=============================================
- Hits           29793    29792       -1     
  Misses          9158     9158              
- Partials        2064     2065       +1     
Files with missing lines Coverage Δ
...rce/impl/derby/HistoryConfigInfoMapperByDerby.java 69.23% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4334cd1...6ac4d1b. Read the comment docs.

@KomachiSion
Copy link
Collaborator

Please fix your commit user and email with your github id and email, otherwise your cla can't pass.

@KomachiSion
Copy link
Collaborator

Fixed by #12796

@Melod-YI
Copy link
Author

Please fix your commit user and email with your github id and email, otherwise your cla can't pass.

got it,
未来有提交会注意。

@Melod-YI Melod-YI deleted the melodyi branch October 31, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants