Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable APSARA_UNIT_TEST_MAIN in provider #2003

Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix: enable APSARA_UNIT_TEST_MAIN in provider #2003

merged 1 commit into from
Jan 1, 2025

Conversation

Abingcbc
Copy link
Collaborator

之前在解决provider代码中ut宏的方法考虑的比较简单，直接移到了主cmake中。导致没有办法同时编译主程序和单测。

修复方案：

  1. 将 APSARA_UNIT_TEST_MAIN 重新移回unittest的cmake中。
  2. provider根据是否编译单测，分别编译 libprovider.a 和 libprovider_unittest_base.a

@yyuuttaaoo yyuuttaaoo merged commit f107577 into alibaba:main Jan 1, 2025
15 checks passed
@yyuuttaaoo yyuuttaaoo added the bug Something isn't working label Jan 1, 2025
@yyuuttaaoo yyuuttaaoo added this to the v3.0 milestone Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linrunqi08 linrunqi08 linrunqi08 approved these changes

@messixukejia messixukejia messixukejia approved these changes

@yyuuttaaoo yyuuttaaoo yyuuttaaoo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Abingcbc @yyuuttaaoo @messixukejia @linrunqi08