fix ut #1980
Open
fix ut #1980
+66
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyuuttaaoo
reviewed
Jan 1, 2025
| processor.AddLabels(*mSpanEvent, container_vec, remote_ip_vec); | ||
| APSARA_TEST_EQUAL("kube-proxy-worker", mSpanEvent->GetTag("peerWorkloadName").to_string()); | ||
| APSARA_TEST_TRUE_FATAL(k8sMetadata.GetInfoByIpFromCache("10.41.0.2") != nullptr); | ||
| APSARA_TEST_TRUE_FATAL(k8sMetadata->GetInfoByIpFromCache("10.41.0.2") != nullptr); | ||
| delete l; |
There was a problem hiding this comment.
mSpanEvent析构的时候应该会自动释放的，这里会double free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
K8sMetadataclass and its associated unit tests to improve memory management and testing coverage. The key changes involve adding a cache-clearing method, modifying the singleton pattern, and updating the unit tests to reflect these changes.Improvements to
K8sMetadataclass:ClearCachemethod toK8sMetadataclass to clearcontainerCacheandipCache. (core/metadata/K8sMetadata.cpp,core/metadata/K8sMetadata.h) [1] [2]K8sMetadatato callClearCache. (core/metadata/K8sMetadata.h)core/metadata/K8sMetadata.h,core/metadata/LabelingK8sMetadata.cpp) [1] [2] [3] [4]Updates to unit tests:
metadata_unittestexecutable and Google Test discovery inCMakeLists.txt. (core/unittest/metadata/CMakeLists.txt)K8sMetadataUnittestto use the new pointer-based singleton and added cache clearing inTearDown. (core/unittest/metadata/K8sMetadataUnittest.cpp) [1] [2] [3] [4] [5] [6]